Skip to content

Document shell-safe PR comment workflow#810

Merged
huangruiteng merged 2 commits into
mainfrom
codex/shell-pr-comment-repair-pattern
Jun 28, 2026
Merged

Document shell-safe PR comment workflow#810
huangruiteng merged 2 commits into
mainfrom
codex/shell-pr-comment-repair-pattern

Conversation

@huangruiteng

Copy link
Copy Markdown
Owner

Summary

  • add a LoopX self-repair pattern for shell command substitution in PR/comment bodies
  • pin the pattern in the interaction-pattern smoke so the badcase remains documented

Validation

  • python3 examples/interaction-pattern-catalog-smoke.py
  • git diff --check
  • loopx check --scan-path skills/loopx-self-repair/references/repair-patterns.md --scan-path examples/interaction-pattern-catalog-smoke.py

Notes

This PR intentionally uses a body file for Markdown-rich PR text.

@huangruiteng

Copy link
Copy Markdown
Owner Author

Self-review summary:

  • Scope: public self-repair documentation plus a focused smoke assertion only.
  • Change: records the shell command-substitution badcase for Markdown-rich PR/comment bodies and recommends single-quoted bodies, stdin/body-file, or connector/API calls.
  • Validation passed locally:
    • python3 examples/interaction-pattern-catalog-smoke.py
    • git diff --check
    • loopx check on the two changed paths
  • Merge status: normal merge is blocked by branch policy; auto-merge is disabled for this repository.

@huangruiteng

Copy link
Copy Markdown
Owner Author

Findings: none from this review pass.

Open questions / assumptions: I treated this as public self-repair documentation plus a focused catalog assertion for shell-safe PR/comment posting. The change is narrow and does not alter runtime behavior.

Validation performed:

  • python3 examples/interaction-pattern-catalog-smoke.py passed on the PR head.

Merge decision: hold for normal reviewer/branch-protection flow; no blocker found.

@huangruiteng huangruiteng merged commit f2a49eb into main Jun 28, 2026
@huangruiteng huangruiteng deleted the codex/shell-pr-comment-repair-pattern branch June 28, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant